From: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Serge Hallyn
<serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Subject: Re: [PATCH v5 4/4] devcg: propagate local changes down the hierarchy
Date: Tue, 19 Feb 2013 16:20:16 -0500 [thread overview]
Message-ID: <20130219212015.GF11173@redhat.com> (raw)
In-Reply-To: <20130219211208.GC5399-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
On Tue, Feb 19, 2013 at 09:12:08PM +0000, Serge E. Hallyn wrote:
> Quoting Aristeu Rozanski (aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org):
> > + } else {
> > + /*
> > + * in the other possible cases:
> > + * root's behavior: allow, devcg's: deny
> > + * root's behavior: deny, devcg's: deny
> > + * the exception will be removed
> > + */
>
> Technically this case isn't needed, right? Will the dev_exception_rm()
> also be done by revalidate_active_exceptions()? So it's safe (but
> not necessary) to drop the else here. Though the comment is very
> informative, and it might be worth keeping the code as is for clarity.
that's correct, it'll end up being removed by
revalidate_active_exceptions(). if others have no objection, I'll keep
it
Thanks for the reviews Serge, much appreciated
--
Aristeu
next prev parent reply other threads:[~2013-02-19 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 16:55 [PATCH v5 0/4] devcg: introduce proper hierarchy support Aristeu Rozanski
2013-02-15 16:55 ` [PATCH v5 1/4] devcg: expand may_access() logic Aristeu Rozanski
2013-02-15 16:55 ` [PATCH v5 2/4] devcg: prepare may_access() for hierarchy support Aristeu Rozanski
2013-02-15 16:55 ` [PATCH v5 3/4] devcg: use css_online and css_offline Aristeu Rozanski
2013-02-15 16:55 ` [PATCH v5 4/4] devcg: propagate local changes down the hierarchy Aristeu Rozanski
[not found] ` <20130215165543.733711059-cd6kKtb6gxi3M6m420IelR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-02-19 21:12 ` Serge E. Hallyn
[not found] ` <20130219211208.GC5399-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2013-02-19 21:20 ` Aristeu Rozanski [this message]
[not found] ` <20130219212015.GF11173-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-13 13:56 ` Aristeu Rozanski
[not found] ` <20130215165543.131282532-cd6kKtb6gxi3M6m420IelR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-02-15 17:23 ` [PATCH v5 0/4] devcg: introduce proper hierarchy support Serge Hallyn
2013-03-19 21:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219212015.GF11173@redhat.com \
--to=aris-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org \
--cc=serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox