cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Peter Zijlstra <a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>
Cc: namhyung.kim-Hm3cg6mZ9cc@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	eranian-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	mhocko-AlSwsSmVLrQ@public.gmane.org,
	paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
	acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHSET] perf, cgroup: implement hierarchy support for perf_event controller
Date: Wed, 10 Apr 2013 11:37:55 +0200	[thread overview]
Message-ID: <20130410093755.GC24443@gmail.com> (raw)
In-Reply-To: <1365579146.30071.24.camel@laptop>


* Peter Zijlstra <a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org> wrote:

> On Mon, 2013-04-08 at 19:23 -0700, Tejun Heo wrote:
> > perf_event cgroup controller is one of the remaining few with broken
> > hierarchy support.  It turns out it's pretty easy to implement - the
> > only thing necessary is making perf_cgroup_match() return %true also
> > when the cgroup of the current task is a descendant of the event's
> > cgroup.  This patchset implements cgroup_is_descendant() and uses it
> > to implement hierarchy support in perf_event controller.
> > 
> > This patchset contains the following three patches.
> > 
> >  0001-cgroup-make-sure-parent-won-t-be-destroyed-before-it.patch
> >  0002-cgroup-implement-cgroup_is_descendant.patch
> >  0003-perf-make-perf_event-cgroup-hierarchical.patch
> 
> Thanks, looks simple and straight fwd. 
> 
> > Ingo, how should these be routed?
> > 
> >  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git perf_event-hierarchy-support
> 
> Ingo typically likes multi-maintainer sets to be pulled from a common
> tree into all relevant maintainer trees so that git merges afterwards
> just-work (tm). But I'll let him expand.

Yeah - at least for larger changes that's a good workflow.

For smaller changes we can pick one or the other tree. Tejun, do these changes 
create any conflicts with the current tip:master tree? If not then you could carry 
these changes in your tree. If there's significant conflicts then it might be 
better to rebase this on top of perf/core and pull them into perf/core. (assuming 
there's no other cgroups prereq patches beyond the ones in this series.)

Thanks,

	Ingo

  reply	other threads:[~2013-04-10  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09  2:23 [PATCHSET] perf, cgroup: implement hierarchy support for perf_event controller Tejun Heo
     [not found] ` <1365474213-13354-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-04-09  2:23   ` [PATCH 1/3] cgroup: make sure parent won't be destroyed before its children Tejun Heo
2013-04-09  2:23   ` [PATCH 2/3] cgroup: implement cgroup_is_descendant() Tejun Heo
2013-04-09  2:23   ` [PATCH 3/3] perf: make perf_event cgroup hierarchical Tejun Heo
2013-04-09  7:07   ` [PATCHSET] perf, cgroup: implement hierarchy support for perf_event controller Li Zefan
2013-04-10  7:32   ` Peter Zijlstra
2013-04-10  9:37     ` Ingo Molnar [this message]
     [not found]       ` <20130410093755.GC24443-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-10 18:01         ` Tejun Heo
2013-04-10 18:08   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130410093755.GC24443@gmail.com \
    --to=mingo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
    --cc=acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=eranian-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=namhyung.kim-Hm3cg6mZ9cc@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).