From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 1/2] vmpressure: in-kernel notifications Date: Tue, 23 Apr 2013 13:11:22 -0400 Message-ID: <20130423171122.GA29983@teo> References: <1366705329-9426-1-git-send-email-glommer@openvz.org> <1366705329-9426-2-git-send-email-glommer@openvz.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1366705329-9426-2-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , Dave Chinner , John Stultz , Joonsoo Kim , Michal Hocko , Kamezawa Hiroyuki , Johannes Weiner On Tue, Apr 23, 2013 at 12:22:08PM +0400, Glauber Costa wrote: > From: Glauber Costa [...] > This patch extends that to also support in-kernel users. Yup, that is the next logical step. ;-) The patches look good to me, just one question... > @@ -227,7 +233,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, > * we account it too. > */ > if (!(gfp & (__GFP_HIGHMEM | __GFP_MOVABLE | __GFP_IO | __GFP_FS))) I wonder if we want to let kernel users to specify the gfp mask here? The current mask is good for userspace notifications, but in-kernel users might be interested in including (or excluding) different types of allocations, e.g. watch only for DMA allocations pressure? Thanks! Anton