Re: [PATCH v6 15/31] fs: convert fs shrinkers to new scan/count API

Artem Bityutskiy
2013-05-13T07:43:26Z

On Mon, 2013-05-13 at 11:28 +0400, Glauber Costa wrote:
> On 05/13/2013 10:12 AM, Artem Bityutskiy wrote:
> > On Sun, 2013-05-12 at 22:13 +0400, Glauber Costa wrote:
> >> From: Dave Chinner <dchinner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>
> >> Convert the filesystem shrinkers to use the new API, and standardise
> >> some of the behaviours of the shrinkers at the same time. For
> >> example, nr_to_scan means the number of objects to scan, not the
> >> number of objects to free.
> >>
> >> I refactored the CIFS idmap shrinker a little - it really needs to
> >> be broken up into a shrinker per tree and keep an item count with
> >> the tree root so that we don't need to walk the tree every time the
> >> shrinker needs to count the number of objects in the tree (i.e.
> >> all the time under memory pressure).
> >
> > UBIFS part looks OK.
> >
> Great. Could I add your acked or reviewed by tag ?

Acked-by: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

--
Best Regards,
Artem Bityutskiy