Re: [PATCH v10 12/35] shrinker: add node awareness

Dave Chinner
2013-06-06T03:26:59Z

On Wed, Jun 05, 2013 at 04:08:10PM -0700, Andrew Morton wrote:
> On Mon, 3 Jun 2013 23:29:41 +0400 Glauber Costa <glommer@openvz.org> wrote:
>
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Pass the node of the current zone being reclaimed to shrink_slab(),
> > allowing the shrinker control nodemask to be set appropriately for
> > node aware shrinkers.
>
> Again, some musings on node hotplug would be interesting.
>
> > --- a/drivers/staging/android/ashmem.c
> > +++ b/drivers/staging/android/ashmem.c
> > @@ -692,6 +692,9 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> > .gfp_mask = GFP_KERNEL,
> > .nr_to_scan = 0,
> > };
> > +
> > + nodes_setall(sc.nodes_to_scan);
>
> hm, is there some way to do this within the initializer? ie:
>
> .nodes_to_scan = magic_goes_here(),

Nothing obvious - it's essentially a memset call, so I'm not sure
how that could be put in the initialiser...

> Also, it's a bit sad to set bits for not-present and not-online nodes.

Yup. Plenty of scope for future optimisation.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org