Re: [PATCH v10 22/35] shrinker: convert remaining shrinkers to count/scan API

Andrew Morton
2013-06-05T23:08:21Z

On Mon, 3 Jun 2013 23:29:51 +0400 Glauber Costa <glommer@openvz.org> wrote:

> From: Dave Chinner <dchinner@redhat.com>
>
> Convert the remaining couple of random shrinkers in the tree to the
> new API.

Gee we have a lot of shrinkers.

> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -4213,13 +4213,14 @@ restart:
> spin_unlock(&kvm->mmu_lock);
> }
>
> -static int mmu_shrink(struct shrinker *shrink, struct shrink_control *sc)
> +static long
> +mmu_shrink_scan(
> + struct shrinker *shrink,
> + struct shrink_control *sc)
>
> ...
>
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> -static int
> -rpcauth_cache_shrinker(struct shrinker *shrink, struct shrink_control *sc)
> +static long
> +rpcauth_cache_shrink_scan(
> + struct shrinker *shrink,
> + struct shrink_control *sc)
> +

It is pretty poor form to switch other people's code into this very
non-standard XFSish coding style. The maintainers are just going to
have to go wtf and switch it back one day.

Really, it would be best if you were to go through the entire patchset
and undo all this.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org