Re: [PATCH v10 12/35] shrinker: add node awareness

Andrew Morton
2013-06-05T23:08:10Z

On Mon, 3 Jun 2013 23:29:41 +0400 Glauber Costa <glommer@openvz.org> wrote:

> From: Dave Chinner <dchinner@redhat.com>
>
> Pass the node of the current zone being reclaimed to shrink_slab(),
> allowing the shrinker control nodemask to be set appropriately for
> node aware shrinkers.

Again, some musings on node hotplug would be interesting.

> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -692,6 +692,9 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> .gfp_mask = GFP_KERNEL,
> .nr_to_scan = 0,
> };
> +
> + nodes_setall(sc.nodes_to_scan);

hm, is there some way to do this within the initializer? ie:

.nodes_to_scan = magic_goes_here(),

Also, it's a bit sad to set bits for not-present and not-online nodes.

> ret = ashmem_shrink(&ashmem_shrinker, &sc);
> sc.nr_to_scan = ret;
> ashmem_shrink(&ashmem_shrinker, &sc);
>
> ...
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org