cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lennart Poettering <lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Daniel P. Berrange"
	<berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>
Subject: Re: [PATCH cgroup/for-3.11] cgroup: disallow rename(2) if sane_behavior
Date: Sun, 16 Jun 2013 09:16:48 +0200	[thread overview]
Message-ID: <20130616071648.GA1978@tango.0pointer.de> (raw)
In-Reply-To: <20130614034717.GA31533-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>

On Thu, 13.06.13 20:47, Tejun Heo (tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org) wrote:

> cgroup's rename(2) isn't a proper migration implementation - it can't
> move the cgroup to a different parent in the hierarchy.  All it can do
> is swapping the name string for that cgroup.  This isn't useful and
> can mislead users to think that cgroup supports proper cgroup-level
> migration.  Disallow rename(2) if sane_behavior.

Note that in the long run I'd really like to see functionality added to
move a full cgroup subtree to a different point in the tree, so that we
can migrate containers and such atomically from one partition to
another, without the container having to be aware of this (which of
course implies that we have a somewhat more useful cgroup namespacing
solution in place).

Lennart

-- 
Lennart Poettering - Red Hat, Inc.

  parent reply	other threads:[~2013-06-16  7:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  3:47 [PATCH cgroup/for-3.11] cgroup: disallow rename(2) if sane_behavior Tejun Heo
     [not found] ` <20130614034717.GA31533-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-06-14  7:44   ` Li Zefan
2013-06-14 18:18   ` [PATCH v2 " Tejun Heo
     [not found]     ` <20130614181822.GC6593-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-18  9:11       ` Li Zefan
2013-06-18 15:16       ` Tejun Heo
2013-06-16  7:16   ` Lennart Poettering [this message]
     [not found]     ` <20130616071648.GA1978-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2013-06-16 22:15       ` [PATCH " Tejun Heo
     [not found]         ` <20130616221556.GC28587-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-06-17 13:00           ` Aristeu Rozanski
     [not found]             ` <20130617130029.GB3212-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-17 17:06               ` Tejun Heo
2013-06-17 13:51           ` Michal Hocko
     [not found]             ` <20130617135122.GD5018-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-06-17 16:51               ` Tejun Heo
     [not found]                 ` <20130617165129.GA32663-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-21  8:35                   ` Michal Hocko
2013-06-17 16:33           ` Lennart Poettering
     [not found]             ` <20130617163353.GD22846-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2013-06-17 16:53               ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130616071648.GA1978@tango.0pointer.de \
    --to=lennart-mdgvqq1h2p+gdvjs77bj7q@public.gmane.org \
    --cc=berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).