From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Anatol Pomozov <anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Subject: Re: [PATCH] cgroups: Do not show inactive devices in cgroups statistics
Date: Wed, 26 Jun 2013 18:23:47 -0700 [thread overview]
Message-ID: <20130627012347.GH4536@htj.dyndns.org> (raw)
In-Reply-To: <20130627012304.GG4536-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
On Wed, Jun 26, 2013 at 06:23:04PM -0700, Tejun Heo wrote:
> Hello,
>
> On Wed, Jun 26, 2013 at 05:37:38PM -0700, Anatol Pomozov wrote:
> > Bottom line: when we set weight for a device then it creates cfq_group
> > and initializes device stats with zero. Later that zero stat is shown
> > even if no activity happened on the device. Both CFQ and our custom IO
> > scheduler have this problem. And because we write set weight for all
> > devices in all cgroups we endup with a lot of zero useless stats.
> >
> > What is the right fix in this situation?
>
> Yeah, I think yours is fine. You're just configuring each blkg during
> init. Please just update the u64 case and repost.
BTW, if there are a lot of users which ignore 0 u64, it may be cleaner
to introduce a wrapper around the existing prfill.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-06-27 1:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 19:26 [PATCH] cgroups: Do not show inactive devices in cgroups statistics Anatol Pomozov
[not found] ` <1372274770-30679-1-git-send-email-anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-06-26 19:36 ` Anatol Pomozov
2013-06-26 20:45 ` Tejun Heo
[not found] ` <20130626204540.GA4536-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-06-26 21:08 ` Vivek Goyal
[not found] ` <20130626210820.GA17564-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-26 21:11 ` Tejun Heo
[not found] ` <CAOS58YP_Umud2DTY+3tc4m02FywGNOEALSN1An4OLXczcmsQ4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-27 0:37 ` Anatol Pomozov
[not found] ` <CAOMFOmVqevNSKgWR5keT8u7vsCRpHhYROejM6OucyNeeA6j6zQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-27 1:23 ` Tejun Heo
[not found] ` <20130627012304.GG4536-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-06-27 1:23 ` Tejun Heo [this message]
2013-06-27 16:37 ` Anatol Pomozov
[not found] ` <1372351046-11976-1-git-send-email-anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-06-27 16:59 ` Tejun Heo
[not found] ` <20130627165943.GA5599-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-27 17:21 ` Anatol Pomozov
2013-06-27 16:39 ` Anatol Pomozov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627012347.GH4536@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox