public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] cpuset: remove redundant checks in file write functions
Date: Tue, 13 Aug 2013 11:05:49 -0400	[thread overview]
Message-ID: <20130813150549.GF26596@mtj.dyndns.org> (raw)
In-Reply-To: <52098941.4070600-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Tue, Aug 13, 2013 at 09:17:53AM +0800, Li Zefan wrote:
> Now cgroup core gets a reference to the css when a cgroup file is
> opened(), and the reference is dropped at file release. so it's
> guaranteed the cpuset is online during the write function.

Hmmm... it doesn't really guarantee that as css's can be offlined with
residual css refcnts, os the css may well be offlined by the time it
reaches the rw functions.  What's guaranteed is that their refcnts
wouldn't be zero.  Eventually we need to implement proper sever
semantics (probably by replacing the custom fs implementation with
sysfs) but right now controllers still need to deal with offline
css's.

Thanks.

-- 
tejun

  parent reply	other threads:[~2013-08-13 15:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13  1:17 [PATCH 1/2] cpuset: remove an unncessary forward declaration Li Zefan
     [not found] ` <5209892D.8070502-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-13  1:17   ` [PATCH 2/2] cpuset: remove redundant checks in file write functions Li Zefan
     [not found]     ` <52098941.4070600-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-13  2:07       ` Li Zefan
2013-08-13 15:05       ` Tejun Heo [this message]
     [not found]         ` <20130813150549.GF26596-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-08-14  2:01           ` Li Zefan
     [not found]             ` <520AE4FC.5090702-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-14 13:30               ` Tejun Heo
     [not found]                 ` <20130814133048.GC28628-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-16  6:48                   ` Li Zefan
2013-08-13 14:53   ` [PATCH 1/2] cpuset: remove an unncessary forward declaration Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813150549.GF26596@mtj.dyndns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox