From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cgroup: change cgroup_from_id() to css_from_id()
Date: Fri, 16 Aug 2013 13:06:59 -0400 [thread overview]
Message-ID: <20130816170659.GM2505@htj.dyndns.org> (raw)
In-Reply-To: <520DCF2C.1020903-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Hello, Li.
On Fri, Aug 16, 2013 at 03:05:16PM +0800, Li Zefan wrote:
> +/**
> + * css_from_id - lookup css by id
> + * @ss: cgroup subsys to be looked into
> + * @id: the cgroup id
> + *
> + * Returns the css if there's valid one with @id, otherwise returns NULL.
> + * Should be called under rcu_read_lock().
> + */
> +struct cgroup_subsys_state *css_from_id(struct cgroup_subsys *ss, int id)
Can we please do css_from_id(int id, struct cgroup_subsys *ss)
instead?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-08-16 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 7:05 [PATCH] cgroup: change cgroup_from_id() to css_from_id() Li Zefan
[not found] ` <520DCF2C.1020903-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-16 17:06 ` Tejun Heo [this message]
[not found] ` <20130816170659.GM2505-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-19 2:05 ` [PATCH v2] " Li Zefan
[not found] ` <52117D64.1010709-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-19 13:53 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816170659.GM2505@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox