From: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
anjana vk <anjanvk12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: cgroup attach task - slogging cpu
Date: Wed, 9 Oct 2013 15:30:47 +0200 [thread overview]
Message-ID: <20131009133047.GA12414@redhat.com> (raw)
In-Reply-To: <5254EB2A.7090803-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On 10/09, Li Zefan wrote:
>
> Anjana, could you revise the patch and send it out with proper changelog
> and Signed-off-by? And please add "Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # 3.9+"
Yes, Anjana, please!
> > check in the main loop. So Anjana was right (sorry again!), and we
> > should probably do
> >
> > ent.cgrp = task_cgroup_from_root(...);
> > if (ent.cgrp != cgrp) {
> > retval = flex_array_put(...);
> > ...
> > }
> >
> > if (!threadgroup)
> > break;
> >
>
> Or
>
> do {
> ...
> if (ent.cgrp == cgrp)
> goto next;
Or this, agreed.
> > Or I am wrong again?
>
> No, you are not! :)
Thanks ;)
Oleg.
next prev parent reply other threads:[~2013-10-09 13:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 5:25 cgroup attach task - slogging cpu anjana vk
[not found] ` <CALPf4Tz+Gf_Q7wKKBufCc1mtV1qVPVrOW0S1qhHxfOv6pJa2Kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-04 13:02 ` Oleg Nesterov
[not found] ` <20131004130207.GA9338-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-07 18:45 ` Tejun Heo
[not found] ` <20131007184507.GD27396-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-10-08 14:58 ` Oleg Nesterov
[not found] ` <20131008145833.GA15600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-09 5:35 ` Li Zefan
[not found] ` <5254EB2A.7090803-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-09 13:30 ` Oleg Nesterov [this message]
[not found] ` <20131009133047.GA12414-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-09 14:05 ` Oleg Nesterov
[not found] ` <20131009140551.GA15849-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-09 16:54 ` cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu) Oleg Nesterov
[not found] ` <20131009165448.GA22437-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-11 13:15 ` Li Zefan
[not found] ` <5257F9E3.5030708-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-11 16:00 ` Oleg Nesterov
[not found] ` <20131011160004.GA26416-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-12 2:59 ` [PATCH] cgroup: fix to break the while loop in cgroup_attach_task() correctly Li Zefan
[not found] ` <5258BB05.8030106-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-13 20:08 ` Tejun Heo
2013-10-15 5:04 ` cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu) anjana vk
[not found] ` <CALPf4Ty_xmred_Mf=tyzKDLu+rqStYUxTazZpYDOCKN_nm-5vQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-15 13:34 ` Tejun Heo
[not found] ` <CAChhN7RerxpSadqyosUeSKFg+qcOpO4d-maEKBZ0rvOQGvN27g@mail.gmail.com>
[not found] ` <CAChhN7RerxpSadqyosUeSKFg+qcOpO4d-maEKBZ0rvOQGvN27g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-10 4:22 ` cgroup attach task - slogging cpu anjana vk
2013-10-10 11:11 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009133047.GA12414@redhat.com \
--to=oleg-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=anjanvk12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).