From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH v2 11/12] cpuset: allow writing offlined masks to cpuset.cpus/mems
Date: Tue, 15 Oct 2013 11:36:01 -0400 [thread overview]
Message-ID: <20131015153601.GM3141@htj.dyndns.org> (raw)
In-Reply-To: <5257CA3A.2040705@huawei.com>
On Fri, Oct 11, 2013 at 05:51:54PM +0800, Li Zefan wrote:
> As the configured masks won't be limited by its parent, and the top
> cpuset's masks won't change when hotplug happens, it's natural to
> allow writing offlined masks to the configured masks.
>
> Signed-off-by; Li Zefan <lizefan@huawei.com>
> ---
> kernel/cpuset.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
> index e71c04f..a98723d 100644
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -960,7 +960,8 @@ static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs,
> if (retval < 0)
> return retval;
>
> - if (!cpumask_subset(trialcs->cpus_allowed, cpu_active_mask))
> + if (!cpumask_subset(trialcs->cpus_allowed,
> + top_cpuset.cpus_allowed))
Shouldn't this gated by sane_behavior?
>
> @@ -1238,8 +1239,8 @@ static int update_nodemask(struct cpuset *cs, struct cpuset *trialcs,
> goto done;
>
> if (!nodes_subset(trialcs->mems_allowed,
> - node_states[N_MEMORY])) {
> - retval = -EINVAL;
> + top_cpuset.mems_allowed)) {
> + retval = -EINVAL;
Ditto.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-10-15 15:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 9:49 [PATCH v2 00/12] cpuset: separate configured masks and effective masks Li Zefan
[not found] ` <5257C9A1.1030404-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-11 9:49 ` [PATCH v2 01/12] cpuset: add cs->effective_cpus and cs->effective_mems Li Zefan
2013-10-11 9:49 ` [PATCH v2 02/12] cpuset: update cpuset->effective_{cpus,mems} at hotplug Li Zefan
2013-10-11 9:50 ` [PATCH v2 03/12] cpuset: update cs->effective_{cpus,mems} when config changes Li Zefan
[not found] ` <5257C9CC.3080806-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-15 15:18 ` Tejun Heo
2013-10-11 9:50 ` [PATCH v2 04/12] cpuset: inherit ancestor's masks if effective_{cpus,mems} becomes empty Li Zefan
2013-10-11 9:50 ` [PATCH v2 05/12] cpuset: use effective cpumask to build sched domains Li Zefan
[not found] ` <5257C9EE.9080902-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-10-15 15:25 ` Tejun Heo
2013-10-11 9:50 ` [PATCH v2 06/12] cpuset: initialize top_cpuset's configured masks at mount Li Zefan
2013-10-11 9:51 ` [PATCH v2 07/12] cpuset: apply cs->effective_{cpus,mems} Li Zefan
2013-10-11 9:51 ` [PATCH v2 08/12] cpuset: make cs->{cpus,mems}_allowed as user-configured masks Li Zefan
2013-10-11 9:51 ` [PATCH v2 09/12] cpuset: refactor cpuset_hotplug_update_tasks() Li Zefan
2013-10-11 9:51 ` [PATCH v2 10/12] cpuset: enable onlined cpu/node in effective masks Li Zefan
2013-10-11 9:51 ` [PATCH v2 11/12] cpuset: allow writing offlined masks to cpuset.cpus/mems Li Zefan
2013-10-15 15:36 ` Tejun Heo [this message]
2013-10-11 9:52 ` [PATCH v2 12/12] cpuset: export effective masks to userspace Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015153601.GM3141@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).