From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH 11/12] cgroup: replace cftype->read_seq_string() with cftype->seq_show() Date: Mon, 2 Dec 2013 09:52:22 -0500 Message-ID: <20131202145222.GA18642@redhat.com> References: <1385595759-17656-1-git-send-email-tj@kernel.org> <1385595759-17656-12-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1385595759-17656-12-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: Jens Axboe , nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org On Wed, Nov 27, 2013 at 06:42:38PM -0500, Tejun Heo wrote: > In preparation of conversion to kernfs, cgroup file handling is > updated so that it can be easily mapped to kernfs. This patch > replaces cftype->read_seq_string() with cftype->seq_show() which is > not limited to single_open() operation and will map directcly to > kernfs seq_file interface. > > The conversions are mechanical. As ->seq_show() doesn't have @css and > @cft, the functions which make use of them are converted to use > seq_css() and seq_cft() respectively. In several occassions, e.f. if > it has seq_string in its name, the function name is updated to fit the > new method better. > > This patch does not introduce any behavior changes. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > Cc: Vivek Goyal > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki > Cc: Neil Horman > Cc: Daniel Wagner > Cc: Aristeu Rozanski > --- > block/blk-throttle.c | 35 ++++++------- > block/cfq-iosched.c | 131 ++++++++++++++++++++-------------------------- Looks good to me for blk-throttle and cfq-iosched part. Acked-by: Vivek Goyal Thanks Vivek