Linux cgroups development
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Viresh Kumar
	<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cpusets: Allocate heap only when required
Date: Fri, 24 Jan 2014 05:36:31 -0500	[thread overview]
Message-ID: <20140124103631.GB4101@htj.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1401240230190.9846-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>

On Fri, Jan 24, 2014 at 02:33:27AM -0800, David Rientjes wrote:
> It's not harmless, if heap_init() fails with -ENOMEM then the write fails 
> even though it may not be for memory_spread_page or memory_spread_slab, 
> which is the minority of the callers of this function.

And depending on details like that would actually be more harmful.
Please remember that all writes through cgroupfs may fail under very
high memory pressure.  There's no "this specific set of writes to this
specific knob isn't affected by memory pressure" guarantee.

Thanks.

-- 
tejun

  parent reply	other threads:[~2014-01-24 10:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8622e93b9c49c66ffdc9ef0aa8371c322718edd5.1390475530.git.viresh.kumar@linaro.org>
     [not found] ` <alpine.DEB.2.02.1401231330530.7313@chino.kir.corp.google.com>
     [not found]   ` <alpine.DEB.2.02.1401231330530.7313-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2014-01-24  1:58     ` [PATCH] cpusets: Allocate heap only when required Li Zefan
     [not found]       ` <52E1C8BD.2010500-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-01-24  4:57         ` Viresh Kumar
     [not found]           ` <CAKohpomn_wgQExfhJL6=MB9LrRhR4=+7t3ehy0d6vEq9duzr8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-24 10:27             ` Tejun Heo
     [not found]               ` <20140124102758.GA4101-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-01-24 10:33                 ` Viresh Kumar
2014-01-24 10:40                   ` Tejun Heo
2014-01-24 10:33       ` David Rientjes
     [not found]         ` <alpine.DEB.2.02.1401240230190.9846-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2014-01-24 10:36           ` Tejun Heo [this message]
     [not found]             ` <20140124103631.GB4101-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-01-24 10:51               ` David Rientjes
     [not found]                 ` <alpine.DEB.2.02.1401240243260.24372-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2014-01-24 10:59                   ` Tejun Heo
2014-01-24 11:15                     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140124103631.GB4101@htj.dyndns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox