cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cgroup: protect modifications to cgroup_idr with cgroup_mutex
Date: Wed, 12 Feb 2014 10:38:32 +0100	[thread overview]
Message-ID: <20140212093832.GD28085@dhcp22.suse.cz> (raw)
In-Reply-To: <52FB3E50.8020809-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Wed 12-02-14 17:26:40, Li Zefan wrote:
> On 2014/2/12 17:12, Michal Hocko wrote:
> > Li has pointed out that my previous backport was not correct because
> > err_unlock label releases a reference to supperblock which was not taken
> > before idr_alloc. I've also removed cgroup_mutex from free_css_id as per
> > Li.
> > Fixed in this version.
> > 
> 
> Looks good to me!

Thanks for double checking.

> Are you going to send it to stable mailing list after the fix hits mainline
> or use it internally?

I plan to have it tested internally and then send it later on when
stable FAILED to apply mail arrives. Unless you want to send it yourself
of course.

> It has small conflicts with this patch that will also be backported to 3.12:
> 
> https://git.kernel.org/cgit/linux/kernel/git/tj/cgroup.git/commit/kernel/cgroup.c?h=for-3.14-fixes&id=b58c89986a77a23658682a100eb15d8edb571ebb

Thanks for the heads up. Should be trivial to resolve.
-- 
Michal Hocko
SUSE Labs

  parent reply	other threads:[~2014-02-12  9:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11  8:05 [PATCH] cgroup: protect modifications to cgroup_idr with cgroup_mutex Li Zefan
     [not found] ` <52F9D9DA.7040108-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-02-11 10:20   ` Michal Hocko
     [not found]     ` <20140211102032.GA11946-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2014-02-12  1:50       ` Li Zefan
2014-02-12  9:12     ` Michal Hocko
2014-02-12  9:26       ` Li Zefan
     [not found]         ` <52FB3E50.8020809-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-02-12  9:38           ` Michal Hocko [this message]
2014-02-11 15:36   ` Tejun Heo
2014-02-11 15:41   ` [PATCH cgroup/for-3.14-fixes] " Tejun Heo
2014-02-11 16:26     ` Michal Hocko
     [not found]       ` <20140211162625.GP11946-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2014-02-12  2:15         ` Li Zefan
     [not found]           ` <52FAD958.6020505-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-02-12  2:32             ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140212093832.GD28085@dhcp22.suse.cz \
    --to=mhocko-alswssmvlrq@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).