cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Li Zefan <lizefan@huawei.com>, Cgroups <cgroups@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernfs: fix kernfs_node_from_dentry()
Date: Fri, 14 Feb 2014 17:04:24 -0500	[thread overview]
Message-ID: <20140214220424.GA4634@mtj.dyndns.org> (raw)
In-Reply-To: <20140214220440.GA3998@kroah.com>

On Fri, Feb 14, 2014 at 02:04:40PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Feb 14, 2014 at 11:03:01AM -0500, Tejun Heo wrote:
> > On Fri, Feb 14, 2014 at 04:57:27PM +0800, Li Zefan wrote:
> > > Currently kernfs_node_from_dentry() returns NULL for root dentry,
> > > because root_dentry->d_op == NULL.
> > > 
> > > Due to this bug cgroupstats_build() returns -EINVAL for root cgroup.
> > > 
> > >   # mount -t cgroup -o cpuacct /cgroup
> > >   # Documentation/accounting/getdelays -C /cgroup
> > >   fatal reply error,  errno -22
> > > 
> > > With this fix:
> > > 
> > >   # Documentation/accounting/getdelays -C /cgroup
> > >   sleeping 305, blocked 0, running 1, stopped 0, uninterruptible 1
> > > 
> > > Signed-off-by: Li Zefan <lizefan@huawei.com>
> > 
> > Acked-by: Tejun Heo <tj@kernel.org>
> 
> Is this needed for 3.14-final or 3.15-rc1?

3.15-rc1, so, driver-core-next.

Thanks.

-- 
tejun

      reply	other threads:[~2014-02-14 22:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  8:57 [PATCH] kernfs: fix kernfs_node_from_dentry() Li Zefan
     [not found] ` <52FDDA77.6070606-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-02-14 16:03   ` Tejun Heo
2014-02-14 22:04     ` Greg Kroah-Hartman
2014-02-14 22:04       ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214220424.GA4634@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).