From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] cgroup: print pretty format in /proc/cgroups Date: Tue, 15 Apr 2014 13:53:25 +0100 Message-ID: <20140415125325.GH13914@redhat.com> References: <1397566065-3028-1-git-send-email-nasa4836@gmail.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1397566065-3028-1-git-send-email-nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jianyu Zhan Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Tue, Apr 15, 2014 at 08:47:45PM +0800, Jianyu Zhan wrote: > I found that /proc/cgroups printed format has ugly alignment(see below). [snip] > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 9fcdaa7..d981697 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -4347,7 +4347,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v) > mutex_lock(&cgroup_mutex); > > for_each_subsys(ss, i) > - seq_printf(m, "%s\t%d\t%d\t%d\n", > + seq_printf(m, "%-16s%-16d%-16d%-16d\n", > ss->name, ss->root->hierarchy_id, > atomic_read(&ss->root->nr_cgrps), !ss->disabled); This is liable to break userspace apps which might currently parse the file by splitting on '\t' Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|