From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
cgroups@vger.kernel.org
Subject: Re: [PATCH RFC] blkcg: prepare blkcg knobs for default hierarchy
Date: Tue, 15 Apr 2014 10:18:26 -0400 [thread overview]
Message-ID: <20140415141826.GB17018@redhat.com> (raw)
In-Reply-To: <20140415140650.GI1863@htj.dyndns.org>
On Tue, Apr 15, 2014 at 10:06:50AM -0400, Tejun Heo wrote:
[..]
> But then do we name other stat knobs similarly too?
>
> blkio.cfq.io_service_sectors
> blkio.cfq.io_service_bytes
> blkio.cfq.io_serviced
> blkio.cfq.io_merged
>
> I don't know. The names look outright stupid to me. If we don't do
> the above, then we have internal inconsistencies among cfq knob names
> which gotta be worse then cfq / throttl inconsistency. It's not a
> perfect situation no matter what we do. As long as each knob is
> clearly documented, I don't think these inconsistencies are big deal,
> so let's just clean up cfq names as we need to add prefix anyway.
Ok, that's fine. Let us just document the knobs well so that people can
find which knob is giving what information and make cfq names better at
the expense of inconsistency of names with throttling layer.
Thanks
Vivek
next prev parent reply other threads:[~2014-04-15 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 1:32 [PATCH RFC] blkcg: prepare blkcg knobs for default hierarchy Tejun Heo
2014-04-14 18:08 ` Vivek Goyal
2014-04-14 19:32 ` Tejun Heo
[not found] ` <20140414193214.GC16835-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-04-15 13:53 ` Vivek Goyal
[not found] ` <20140415135359.GA13033-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-15 14:06 ` Tejun Heo
2014-04-15 14:18 ` Vivek Goyal [this message]
[not found] ` <20140415141826.GB17018-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-23 17:01 ` Tejun Heo
[not found] ` <20140423170141.GJ4781-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-04-23 17:17 ` Vivek Goyal
2014-04-23 18:52 ` Tejun Heo
[not found] ` <20140423185231.GA4163-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-04-23 18:58 ` Vivek Goyal
2014-04-23 19:00 ` Tejun Heo
[not found] ` <20140423190043.GB4163-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-04-23 19:21 ` Vivek Goyal
2014-04-23 19:27 ` Tejun Heo
2014-05-23 17:39 ` Tejun Heo
2014-05-27 12:49 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415141826.GB17018@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).