From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jianyu Zhan <nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] cgroup: clean up obsolete comment for parse_cgroupfs_options()
Date: Thu, 17 Apr 2014 11:38:00 -0400 [thread overview]
Message-ID: <20140417153800.GO15326@htj.dyndns.org> (raw)
In-Reply-To: <1397748555-6647-1-git-send-email-nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thu, Apr 17, 2014 at 11:29:15PM +0800, Jianyu Zhan wrote:
> Commit 1d5be6b287c8efc87(cgroup: move module ref handling into
> rebind_subsystems()) makes parse_cgroupfs_options() no longer
> takes refcounts on subsystems.
>
> And unified hierachy makes parse_cgroupfs_options not need to
> call with cgroup_mutex held to protect the cgroup_subsys[].
>
> So this patch cleanups these comment and BUG_ON().
>
> Signed-off-by: Jianyu Zhan <nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Rolled 1-3 to the pending patchset. Will be applied after the unified
patchset. I dropped the comment above parse_cgroupfs_options()
altogether as it didn't contain anything actually useful. Also, next
time, please put the patches in a series into a thread so that they're
easier to track.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-17 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 15:29 [PATCH 1/3] cgroup: clean up obsolete comment for parse_cgroupfs_options() Jianyu Zhan
[not found] ` <1397748555-6647-1-git-send-email-nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-17 15:38 ` Tejun Heo [this message]
[not found] ` <20140417153800.GO15326-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-04-17 15:40 ` Jianyu Zhan
2014-04-17 18:05 ` [PATCH] cgroup: Use more current logging style Joe Perches
2014-04-17 19:14 ` Tejun Heo
[not found] ` <20140417191416.GS15326-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-04-27 11:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417153800.GO15326@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox