From: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Serge Hallyn
<serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] device_cgroup: rework device access check and exception checking
Date: Wed, 23 Apr 2014 10:32:27 -0400 [thread overview]
Message-ID: <20140423143226.GK29214@redhat.com> (raw)
In-Reply-To: <20140421223253.GB22730-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
On Mon, Apr 21, 2014 at 06:32:53PM -0400, Tejun Heo wrote:
> On Mon, Apr 21, 2014 at 12:13:03PM -0400, Aristeu Rozanski wrote:
> > Whenever a device file is opened and checked against current device
> > cgroup rules, it uses the same function (may_access()) as when a new
> > exception rule is added by writing devices.{allow,deny}. And in both
> > cases, the algorithm is the same, doesn't matter the behavior.
> ...
> > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> > Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Signed-off-by: Aristeu Rozanski <arozansk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Applied to cgroup/for-3.15-fixes.
>
> A nit: Can you please prepare a separate patch to reformat the
> function comments. The usual style is single line at the top for the
> function name and brief description. The actual description should
> come after the param list.
Will submit with a v3, another bug found :\
--
Aristeu
next prev parent reply other threads:[~2014-04-23 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 16:13 [PATCH] device_cgroup: rework device access check and exception checking Aristeu Rozanski
[not found] ` <20140421161303.GG29214-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-21 22:32 ` Tejun Heo
[not found] ` <20140421223253.GB22730-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-04-23 14:32 ` Aristeu Rozanski [this message]
[not found] ` <20140423143226.GK29214-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-23 14:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423143226.GK29214@redhat.com \
--to=aris-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox