From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aristeu Rozanski Subject: Re: [PATCH] device_cgroup: fix the comment format for recently added functions Date: Fri, 2 May 2014 11:49:59 -0400 Message-ID: <20140502154959.GH29214@redhat.com> References: <20140424193321.GS29214@redhat.com> <20140502153028.GG10204@htj.dyndns.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20140502153028.GG10204-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Serge Hallyn , Li Zefan Hi Tejun, On Fri, May 02, 2014 at 11:30:28AM -0400, Tejun Heo wrote: > On Thu, Apr 24, 2014 at 03:33:21PM -0400, Aristeu Rozanski wrote: > > @@ -306,17 +306,17 @@ static int devcgroup_seq_show(struct seq_file *m, void *v) > > } > > > > /** > > - * match_exception - iterates the exception list trying to match a rule > > - * based on type, major, minor and access type. It is > > - * considered a match if an exception is found that > > - * will contain the entire range of provided parameters. > > + * match_exception - iterates the exception list trying to find a complete match > > * @exceptions: list of exceptions > > * @type: device type (DEV_BLOCK or DEV_CHAR) > > * @major: device file major number, ~0 to match all > > * @minor: device file minor number, ~0 to match all > > * @access: permission mask (ACC_READ, ACC_WRITE, ACC_MKNOD) > > * > > - * returns: true in case it matches an exception completely > > + * It is considered a complete match if an exception is found that will > > + * contain the entire range of provided parameters. > > + * > > + * Return: true in case it matches an exception completely > > Can you just merge "Return: " section into the paragraph? Just go > "Returns true blah blah". That goes against Documentation/kernel-doc-nano-HOWTO.txt. -- Aristeu