From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH RFC - TAKE TWO - 06/12] block, bfq: improve responsiveness
Date: Fri, 30 May 2014 11:41:23 -0400
Message-ID: <20140530154123.GD24871@htj.dyndns.org>
References: <20140528221929.GG1419@htj.dyndns.org>
	<1401354343-5527-1-git-send-email-paolo.valente@unimore.it>
	<1401354343-5527-7-git-send-email-paolo.valente@unimore.it>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:date:from:to:cc:subject:message-id:references:mime-version
	:content-type:content-disposition:in-reply-to:user-agent;
	bh=Clf18GAtm22DG0wnYuHwdH0zQotZoQHyVmoz3BG+dDk=;
	b=SdKCWVqTTzAlJKy5kywXn+5gvwbXHuSQ6ij9qrX6FTwHhiDu8iIMpBKymCqyY7JAq4
	r15YXRsxKPoTedEUh28sLEOMjAqtwlTOi004+qyhVP43ffgZOQoayDnar4TarhtREQkS
	x3tOeCQ9184IzY0K+OeufVzSo9h/5mlu3uOf/1r3ACeENw3I2j2vVXGB4+9G02StpAdf
	W3/kjVGb2meJL9yoeje9FWam03iEAZRktsc3gu/7h1BlX65eSTESaSyVYRzUaY8ZVHOU
	KoFkZ1gObCz3mx5uKzH/vNxRvrhXxlVqptEie2e/d0BE/hLIDU8jYmIsJX9OjDwjJmSy
	bqdg==
Content-Disposition: inline
In-Reply-To: <1401354343-5527-7-git-send-email-paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org>
List-Id: <cgroups.vger.kernel.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/containers>, 
	<mailto:containers-request-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/containers/>
List-Post: <mailto:containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
List-Help: <mailto:containers-request-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/containers>,
	<mailto:containers-request-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org?subject=subscribe>
Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
To: Paolo Valente <paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org>
Cc: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fabio Checconi <fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Arianna Avanzini <avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paolo Valente <posta_paolo-whZMOeQn8C0@public.gmane.org>

On Thu, May 29, 2014 at 11:05:37AM +0200, Paolo Valente wrote:
> @@ -281,7 +323,8 @@ static inline unsigned long bfq_serv_to_charge(struct request *rq,
>  					       struct bfq_queue *bfqq)
>  {
>  	return blk_rq_sectors(rq) *
> -		(1 + ((!bfq_bfqq_sync(bfqq)) * bfq_async_charge_factor));
> +		(1 + ((!bfq_bfqq_sync(bfqq)) * (bfqq->wr_coeff == 1) *
> +		bfq_async_charge_factor));

Ah, okay, so you actually use it later.  Please disregard my previous
comment about dropping the wrapper.

Thanks.

-- 
tejun