From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH v3 05/12] cpuset: use effective cpumask to build sched domains
Date: Wed, 9 Jul 2014 15:18:36 -0400 [thread overview]
Message-ID: <20140709191836.GA21090@htj.dyndns.org> (raw)
In-Reply-To: <53BD01B6.403@huawei.com>
On Wed, Jul 09, 2014 at 04:47:50PM +0800, Li Zefan wrote:
> + /*
> + * If the effective cpumask of any non-empty cpuset is changed,
> + * we need to rebuild sched domains.
> + */
> + if (!cpumask_empty(cp->cpus_allowed) &&
> + is_sched_load_balance(cp))
> + need_rebuild_sched_domains = true;
Hmmm... is this because if cpus_allowed is empty, the effective always
equals the parent? If so, let's update the comment so that it
explains why the code is like that. The current comment just explains
what it does which isn't very helpful.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-09 19:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 8:46 [PATCH v3 00/12] cpuset: separate configured masks and effective masks Li Zefan
2014-07-09 8:47 ` [PATCH v3 01/12] cpuset: add cs->effective_cpus and cs->effective_mems Li Zefan
[not found] ` <53BD0187.9060309-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-09 16:47 ` Tejun Heo
2014-07-09 8:47 ` [PATCH v3 02/12] cpuset: update cpuset->effective_{cpus,mems} at hotplug Li Zefan
2014-07-09 8:47 ` [PATCH v3 03/12] cpuset: update cs->effective_{cpus,mems} when config changes Li Zefan
[not found] ` <53BD01A1.2060302-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-09 19:57 ` Tejun Heo
2014-07-09 8:47 ` [PATCH v3 04/12] cpuset: inherit ancestor's masks if effective_{cpus,mems} becomes empty Li Zefan
2014-07-09 8:47 ` [PATCH v3 05/12] cpuset: use effective cpumask to build sched domains Li Zefan
2014-07-09 19:18 ` Tejun Heo [this message]
[not found] ` <53BD0174.4060002-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-09 8:48 ` [PATCH v3 06/12] cpuset: initialize top_cpuset's configured masks at mount Li Zefan
2014-07-09 20:12 ` [PATCH v3 00/12] cpuset: separate configured masks and effective masks Tejun Heo
2014-07-09 8:48 ` [PATCH v3 07/12] cpuset: apply cs->effective_{cpus,mems} Li Zefan
2014-07-09 8:48 ` [PATCH v3 08/12] cpuset: make cs->{cpus,mems}_allowed as user-configured masks Li Zefan
2014-07-09 8:48 ` [PATCH v3 09/12] cpuset: refactor cpuset_hotplug_update_tasks() Li Zefan
2014-07-09 8:49 ` [PATCH v3 10/12] cpuset: enable onlined cpu/node in effective masks Li Zefan
2014-07-09 8:49 ` [PATCH v3 11/12] cpuset: allow writing offlined masks to cpuset.cpus/mems Li Zefan
2014-07-09 8:49 ` [PATCH v3 12/12] cpuset: export effective masks to userspace Li Zefan
[not found] ` <53BD0215.8060305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-09 20:15 ` Tejun Heo
[not found] ` <20140709201549.GD21090-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-07-09 20:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709191836.GA21090@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).