From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Mike Qiu
<qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: WARNING: at kernel/cpuset.c:1139
Date: Mon, 28 Jul 2014 15:20:26 -0400 [thread overview]
Message-ID: <20140728192026.GI7462@htj.dyndns.org> (raw)
In-Reply-To: <53D052FC.3070409-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote:
> On 2014/7/23 23:12, Tejun Heo wrote:
> > On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
> >> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config
> >> changes") introduce the below warning in my server.
> >>
> >> [ 35.652137] ------------[ cut here ]------------
> >> [ 35.652141] WARNING: at kernel/cpuset.c:1139
> >
> > Hah, can you reproduce it? If so, can you detail how?
> >
>
> It's a typo.
>
> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
> nodes_equal(cp->mems_allowed, cp->effective_mems));
>
> should be
>
> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
> !nodes_equal(cp->mems_allowed, cp->effective_mems));
Care to post a patch?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-28 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 2:50 WARNING: at kernel/cpuset.c:1139 Mike Qiu
2014-07-23 15:12 ` Tejun Heo
[not found] ` <20140723151220.GD7103-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-07-24 0:27 ` Li Zefan
[not found] ` <53D052FC.3070409-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-24 2:46 ` Mike Qiu
2014-07-28 19:20 ` Tejun Heo [this message]
[not found] ` <20140728192026.GI7462-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-07-29 9:07 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728192026.GI7462@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox