Re: [PATCH] cgroup: add tracepoints to track cgroup events

Andrea Righi
2014-08-21T15:35:41Z

On Thu, Aug 21, 2014 at 09:13:30AM -0500, Tejun Heo wrote:
> Hello,
>
> On Wed, Aug 20, 2014 at 09:46:25PM -0600, Andrea Righi wrote:
> > This patch adds the following tracepoints:
> > o trace_cgroup_create when a new cgroup is created
> > o trace_cgroup_destroy when a cgroup is removed
> > o trace_cgroup_task_migrate when a task/thread is moved from a cgroup to another
> >
> > The purpose of these tracepoints is to identify and help cgroup "managers" to
> > diagnose problems and detect when they are doing an excessive amount of work.
>
> Using TPs for this looks like a really roundabout way of doing this
> when the whole interface is based on filesystem. Extending
> kernfs_notity to support directory events seems like a better way to
> do this.
>
> Thanks.
>
> --
> tejun

Agreed. Thanks for the suggestion, Tejun.

-Andrea