public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <andrea@betterlinux.com>
Cc: Li Zefan <lizefan@huawei.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matt Heaton <matt@betterlinux.com>
Subject: Re: [PATCH] cgroup: add tracepoints to track cgroup events
Date: Thu, 21 Aug 2014 12:07:01 -0500	[thread overview]
Message-ID: <20140821170701.GA3940@mtj.dyndns.org> (raw)
In-Reply-To: <20140821170002.GB7625@Dell>

Hello, Anrea.

On Thu, Aug 21, 2014 at 11:00:02AM -0600, Andrea Righi wrote:
> hmm... am I missing something or we already support directory events?

Ah, right, those mkdir/rmdir and writes automatically generate those
events.

> root@Dell:~# grep cgroups /proc/mounts
> none /cgroups cgroup rw,relatime,cpuset,cpu,cpuacct,memory,devices,freezer,perf_event,hugetlb 0 0
> root@Dell:~# inotifywait -m -r -e modify -e move -e create -e delete /cgroups
> Setting up watches.  Beware: since -r was given, this may take a while!
> Watches established.
> /cgroups/ CREATE,ISDIR test
> /cgroups/test/ MODIFY cgroup.procs
> /cgroups/test/ MODIFY cgroup.procs
> /cgroups/test/ MODIFY cgroup.populated
> /cgroups/ MODIFY cgroup.procs
> /cgroups/ MODIFY cgroup.procs
> /cgroups/test/ MODIFY cgroup.populated
> /cgroups/ DELETE,ISDIR test
> 
> I still need to figure out a smart way to track which PIDs are
> added/removed to/from cgroup.procs from userland (inotifywait + git? :)),
> but all the other informations provided by my tracepoint patch seem to
> be already available via [di]notify.

Hmmm... yeah, determining exactly which pids got added / removed can
be cumbersome from just MODIFY events.  That said, what are you trying
to do with such information?

Thanks.

-- 
tejun

  reply	other threads:[~2014-08-21 17:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21  3:46 [PATCH] cgroup: add tracepoints to track cgroup events Andrea Righi
     [not found] ` <1408592785-6700-1-git-send-email-andrea-oIIqvOZpAevzfdHfmsDf5w@public.gmane.org>
2014-08-21 14:13   ` Tejun Heo
     [not found]     ` <20140821141330.GA1766-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-08-21 15:35       ` Andrea Righi
2014-08-21 17:00         ` Andrea Righi
2014-08-21 17:07           ` Tejun Heo [this message]
     [not found]             ` <20140821170701.GA3940-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-08-21 17:45               ` Andrea Righi
2014-08-21 23:45             ` Steven Rostedt
     [not found]               ` <20140821194514.0e97b26a-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2014-08-22  4:05                 ` Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140821170701.GA3940@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=andrea@betterlinux.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=matt@betterlinux.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox