From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [patch 1/3] mm: memcontrol: take a css reference for each charged page Date: Mon, 22 Sep 2014 12:24:02 +0400 Message-ID: <20140922082402.GA18526@esperanza> References: <1411243235-24680-1-git-send-email-hannes@cmpxchg.org> <1411243235-24680-2-git-send-email-hannes@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1411243235-24680-2-git-send-email-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: linux-mm@kvack.org, Michal Hocko , Greg Thelen , Tejun Heo , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, Sep 20, 2014 at 04:00:33PM -0400, Johannes Weiner wrote: > Charges currently pin the css indirectly by playing tricks during > css_offline(): user pages stall the offlining process until all of > them have been reparented, whereas kmemcg acquires a keep-alive > reference if outstanding kernel pages are detected at that point. > > In preparation for removing all this complexity, make the pinning > explicit and acquire a css references for every charged page. > > Signed-off-by: Johannes Weiner Reviewed-by: Vladimir Davydov Nit: In __mem_cgroup_clear_mc, we have the following hunk: > for (i = 0; i < mc.moved_swap; i++) > css_put(&mc.from->css); Now we can simplify it using css_put_many. Thanks, Vladimir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org