Re: [patch] mm: memcontrol: do not iterate uninitialized memcgs

Tejun Heo
2014-09-25T02:57:58Z

Hello,

On Wed, Sep 24, 2014 at 10:31:18PM -0400, Johannes Weiner wrote:
..
> not meet the ordering requirements for memcg, and so we still may see
> partially initialized memcgs from the iterators.

It's mainly the other way around - a fully initialized css may not
show up in an iteration, but given that there's no memory ordering or
synchronization around the flag, anything can happen.

...
> + if (next_css == &root->css ||
> + css_tryget_online(next_css)) {
> + struct mem_cgroup *memcg;
> +
> + memcg = mem_cgroup_from_css(next_css);
> + if (memcg->initialized) {
> + /*
> + * Make sure the caller's accesses to
> + * the memcg members are issued after
> + * we see this flag set.

I usually prefer if the comment points to the exact location that the
matching memory barriers live. Sometimes it's difficult to locate the
partner barrier even w/ the functional explanation.

> + */
> + smp_rmb();
> + return memcg;

In an unlikely event this rmb becomes an issue, a self-pointing
pointer which is set/read using smp_store_release() and
smp_load_acquire() respectively can do with plain barrier() on the
reader side on archs which don't need data dependency barrier
(basically everything except alpha). Not sure whether that'd be more
or less readable than this tho.

Thanks.

--
tejun