Re: [PATCH v2 2/2] cgroups: add an nproc subsystem

Zefan Li
2015-03-09T01:49:45Z

Hi Tejun,

On 2015/3/2 23:22, Tejun Heo wrote:
> Hello,
>
> On Fri, Feb 27, 2015 at 03:17:19PM +1100, Aleksa Sarai wrote:
>> +config CGROUP_NPROC
>> + bool "Process number limiting on cgroups"
>> + depends on PAGE_COUNTER
>> + help
>> + This options enables the setting of process number limits in the scope
>> + of a cgroup. Any attempt to fork more processes than is allowed in the
>> + cgroup will fail. This allows for more basic resource limitation that
>> + applies to a cgroup, similar to RLIMIT_NPROC (except that instead of
>> + applying to a process tree it applies to a cgroup).
>
> Please reflect the rationale from this discussion thread in the commit
> message and help text. Also, I'd much prefer to name it pids
> controller after the resource it's controlling.
>

Seems we are going to accept this feature. Is it because kmemcg won't be able
to fullfill this requirement? And that's because kmemcg can only and will only
be able to control global kernel memory usage?

I thought there will be some control file like kmem.pids.max, which will
translate the number of processes to the kernel memory needed, and fail memory
allocation if we reach the limit, for example make task_struct slab return
NULL.