public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Aleksa Sarai <cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
Cc: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	richard-/L3Ra7n9ekc@public.gmane.org,
	"Frédéric Weisbecker"
	<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 3/4] cgroups: allow a cgroup subsystem to reject a fork
Date: Mon, 6 Apr 2015 11:05:36 -0400	[thread overview]
Message-ID: <20150406150536.GA10582@htj.duckdns.org> (raw)
In-Reply-To: <CAOviyai9dvCTGK=VUm0uDSo7XbmKk1BFDrRzL15ppAWf8YjG3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hello, Aleksa.

On Fri, Apr 03, 2015 at 10:42:27AM +1100, Aleksa Sarai wrote:
> I tried doing this and the kernel would refuse to boot. I believe it has
> something to do with the ordering of early_init subsystems, but I'm not

Hmmm... yeah, failure in early_init can be tricky to debug.

> entirely sure (this optimisation can be dealt with later [it's non-critical],
> so IMO this should be done in a separate patchset [if at all]). Also, your
> later comments would fix the subsys bitmask problem (we can just pass the
> default %NULL), we don't even need to test the index.

But we'd be adding quite a few loops in relatively hot paths.  I don't
think it's a good idea to send the patches as-are because we can't
debug and fix them properly, right?  If there are hard ordering
dependencies, the range of subsystems which require fork/exit doesn't
have to be at the beginning.

Thanks.

-- 
tejun

  parent reply	other threads:[~2015-04-06 15:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  8:57 [PATCH v8 0/4] cgroups: add pids subsystem Aleksa Sarai
     [not found] ` <1427878641-5273-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-04-01  8:57   ` [PATCH v8 1/4] cgroups: use bitmask to filter for_each_subsys Aleksa Sarai
2015-04-01  8:57 ` [PATCH v8 2/4] cgroups: replace explicit ss_mask checking with for_each_subsys_which Aleksa Sarai
2015-04-01  8:57 ` [PATCH v8 3/4] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
     [not found]   ` <1427878641-5273-4-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-04-01 16:02     ` Tejun Heo
     [not found]       ` <20150401160258.GP9974-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-02 23:42         ` Aleksa Sarai
     [not found]           ` <CAOviyai9dvCTGK=VUm0uDSo7XbmKk1BFDrRzL15ppAWf8YjG3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-06 15:05             ` Tejun Heo [this message]
2015-04-07 13:47               ` Aleksa Sarai
     [not found]                 ` <CAOviyagYWk1VJW3upKsOS8rOiBQFTn752eJA_C2SkHnCh7EUrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-07 14:00                   ` Tejun Heo
2015-04-01  8:57 ` [PATCH v8 4/4] cgroups: implement the PIDs subsystem Aleksa Sarai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150406150536.GA10582@htj.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org \
    --cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=richard-/L3Ra7n9ekc@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox