From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org,
richard@nod.at, "Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v9 3/4] cgroups: allow a cgroup subsystem to reject a fork
Date: Fri, 17 Apr 2015 16:42:06 -0400 [thread overview]
Message-ID: <20150417204206.GI16743@htj.duckdns.org> (raw)
In-Reply-To: <CAOviyagcvtpDL1OONXR_-fX6X6N+-KfDw5mmpn=iQU+ZNps02g@mail.gmail.com>
On Sat, Apr 18, 2015 at 06:35:41AM +1000, Aleksa Sarai wrote:
> >> Do you also want me to completely drop the COUNT macro? IMO it makes
> >> the CGROUP_<TAG>_COUNT consolidation much nicer.
> >
> > What's wrong with simply having start and end tags?
>
> Because you'd have to write (CGROUP_TAG_END - CGROUP_TAG_START) every
> time? It's a small addition and it makes referencing the range of a
> tagged section much easier.
Wouldn't loops look more like
for (subsys = CGROUP_TAG_START; subsys < CGROUP_TAG_END; subsys++)
And even if not, just define a separate macro for the length. It's
not like we're gonna have a lot of tags.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-04-17 20:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 0:51 [PATCH v9 0/4] cgroups: add pids subsystem Aleksa Sarai
[not found] ` <1428799917-15141-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-04-12 0:51 ` [PATCH v9 1/4] cgroups: use bitmask to filter for_each_subsys Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 3/4] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
[not found] ` <1428799917-15141-4-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-04-13 14:24 ` Tejun Heo
2015-04-14 0:33 ` Aleksa Sarai
[not found] ` <CAOviyajqc_ip2Lpa5NTLLXxQ7JghYXg1UL3vXDdpbbnhmsfXEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-14 12:17 ` Tejun Heo
[not found] ` <20150414121732.GL2596-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-16 13:57 ` Aleksa Sarai
[not found] ` <CAOviyaj6eQ6s50+DrQN8yFAp7q5Y6b4ReFOT8XT0UufPb5J0xQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-17 14:45 ` Tejun Heo
[not found] ` <20150417144519.GC1954-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-17 20:35 ` Aleksa Sarai
2015-04-17 20:42 ` Tejun Heo [this message]
[not found] ` <20150417204206.GI16743-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-17 20:48 ` Aleksa Sarai
[not found] ` <CAOviyah2dBbc5MecxzCfOt36dVfCaN7F7u+5ycPmp3eVDc_J2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-17 20:55 ` Tejun Heo
[not found] ` <20150417205545.GJ16743-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-17 21:06 ` Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 2/4] cgroups: replace explicit ss_mask checking with for_each_subsys_which Aleksa Sarai
2015-04-12 0:51 ` [PATCH v9 4/4] cgroups: implement the PIDs subsystem Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417204206.GI16743@htj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox