Re: [PATCH] sched: Relax a restriction in sched_rt_can_attach()

Mike Galbraith
2015-05-04T05:39:24Z

On Mon, 2015-05-04 at 07:10 +0200, Mike Galbraith wrote:
> On Mon, 2015-05-04 at 12:39 +0800, Zefan Li wrote:
>
> > >> We are moving toward unified hierarchy where all the cgroup controllers
> > >> are bound together, so it would make cgroups easier to use if we have less
> > >> restrictions on attaching tasks between cgroups.
> > >
> > > Forcing group scheduling overhead on users if they want cpuset or memory
> > > cgroup functionality would be far from wonderful. Am I interpreting the
> > > implications of this unification/binding properly?
> > >
> > > (I hope not, surely the plan is not to utterly _destroy_ cgroup utility)
> > >
> >
> > Some degree of flexibility is provided so that you may disable some controllers
> > in a subtree. For example:
> >
> > root ---> child1
> > (cpuset,memory,cpu) (cpuset,memory)
> > \
> > \-> child2
> > (cpu)
>
> Whew, that's a relief. Thanks.

But somehow I'm not feeling a whole lot better.

"May" means if you don't explicitly take some action to disable group
scheduling, you get it (I don't care if I have an off button), but that
would also seemingly mean that we would then have rt tasks in taskgroups
with no bandwidth allocated, ie you have to make group scheduling for rt
tasks meaningless until a bandwidth appeared, and to make bandwidth
appear, you'd have to stop the world, distribute, continue, no?

The current "just say no" seems a lot more sensible.

-Mike