From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Mike Galbraith
<umgwanakikbuti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] sched: Relax a restriction in sched_rt_can_attach()
Date: Tue, 5 May 2015 15:06:03 -0400 [thread overview]
Message-ID: <20150505190603.GZ1971@htj.duckdns.org> (raw)
In-Reply-To: <20150505190057.GR23123-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
Hello, Peter.
On Tue, May 05, 2015 at 09:00:57PM +0200, Peter Zijlstra wrote:
> On Tue, May 05, 2015 at 12:31:12PM -0400, Tejun Heo wrote:
> > What I don't want to happen is controllers failing migrations
> > willy-nilly for random reasons leaving users baffled, which we've
> > actually been doing unfortunately. Maybe we need to deal with this
> > fixed resource arbitration as a separate class and allow them to fail
> > migration w/ -EBUSY.
>
> Ah, _that_ was the problem.
>
> Which is something created by this co-mounting of controllers.
Yeah, partly, but also that it's an extra failure mode which isn't
necessary for most controllers.
> You could of course store the ss-id of the failing operation in
> task_struct and have a file reporting the name of the ss-id.
>
> That way, there is a simple way to find out which controller failed the
> migrate.
Given that the resources which can fail are very limited, I don't
think we need that right now as long as we limit and document the
possible failure cases clearly. Hopefully, this won't devolve into
collection of arbitrary failures.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-05-05 19:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 0:54 [PATCH] sched: Relax a restriction in sched_rt_can_attach() Zefan Li
[not found] ` <5546C34C.7050202-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-05-04 3:13 ` Mike Galbraith
[not found] ` <1430709236.3129.42.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-04 4:39 ` Zefan Li
[not found] ` <5546F80B.3070802-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-05-04 5:10 ` Mike Galbraith
[not found] ` <1430716247.3129.44.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-04 5:39 ` Mike Galbraith
[not found] ` <1430717964.3129.62.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-04 9:11 ` Zefan Li
[not found] ` <554737AE.5040402-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-05-04 12:08 ` Mike Galbraith
2015-05-04 12:37 ` Peter Zijlstra
2015-05-04 14:09 ` Mike Galbraith
[not found] ` <1430748582.3166.16.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-05 3:46 ` Zefan Li
[not found] ` <55483CF8.8030908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-05-05 6:02 ` Mike Galbraith
[not found] ` <20150504123738.GZ21418-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-05-05 3:54 ` Zefan Li
2015-05-05 14:10 ` Peter Zijlstra
2015-05-05 14:18 ` Tejun Heo
2015-05-05 15:19 ` Peter Zijlstra
2015-05-05 16:31 ` Tejun Heo
2015-05-05 19:00 ` Peter Zijlstra
[not found] ` <20150505190057.GR23123-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-05-05 19:06 ` Tejun Heo [this message]
[not found] ` <20150505190603.GZ1971-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-05-06 8:49 ` Peter Zijlstra
2015-05-05 14:41 ` Tejun Heo
2015-05-05 15:11 ` Peter Zijlstra
2015-05-05 16:13 ` Tejun Heo
2015-05-05 16:50 ` Peter Zijlstra
2015-05-05 18:29 ` Thomas Gleixner
2015-05-05 19:00 ` Tejun Heo
2015-05-06 9:12 ` Thomas Gleixner
2015-05-05 18:31 ` Tejun Heo
2015-05-05 14:09 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505190603.GZ1971@htj.duckdns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=umgwanakikbuti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox