Re: [PATCH 1/2] gfp: add __GFP_NOACCOUNT

Johannes Weiner
2015-05-06T17:52:12Z

On Wed, May 06, 2015 at 04:58:14PM +0200, Michal Hocko wrote:
> On Tue 05-05-15 12:45:42, Vladimir Davydov wrote:
> [...]
> > diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> > index 97a9373e61e8..37c422df2a0f 100644
> > --- a/include/linux/gfp.h
> > +++ b/include/linux/gfp.h
> > @@ -30,6 +30,7 @@ struct vm_area_struct;
> > #define ___GFP_HARDWALL 0x20000u
> > #define ___GFP_THISNODE 0x40000u
> > #define ___GFP_RECLAIMABLE 0x80000u
> > +#define ___GFP_NOACCOUNT 0x100000u
> > #define ___GFP_NOTRACK 0x200000u
> > #define ___GFP_NO_KSWAPD 0x400000u
> > #define ___GFP_OTHER_NODE 0x800000u
> > @@ -87,6 +88,7 @@ struct vm_area_struct;
> > #define __GFP_HARDWALL ((__force gfp_t)___GFP_HARDWALL) /* Enforce hardwall cpuset memory allocs */
> > #define __GFP_THISNODE ((__force gfp_t)___GFP_THISNODE)/* No fallback, no policies */
> > #define __GFP_RECLAIMABLE ((__force gfp_t)___GFP_RECLAIMABLE) /* Page is reclaimable */
> > +#define __GFP_NOACCOUNT ((__force gfp_t)___GFP_NOACCOUNT) /* Don't account to memcg */
>
> The wording suggests that _any_ memcg charge might be skipped by this flag
> but only kmem part is handled.
>
> So either handle the flag in try_charge or, IMO preferably, update the
> comment here and add WARN_ON{_ONCE}(gfp & __GFP_NOACCOUNT). I do not
> think we should allow to skip the charge for user pages ATM and warning
> could tell us about the abuse of the flag.

Michal, please just stop.

There is no reason to warn the user about this whatsoever. If you
want to prevent abuse - whatever that means - program your mailreader
to flag patches containing __GFP_NOACCOUNT and review them carefully.

This eagerness to clutter the code with defensiveness against the rest
of the kernel tree and to disrupt the user over every little blip that
has nothing to do with them is really getting old at this point.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org