From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Subject: Re: Possible bug - LTP failure for memcg Date: Thu, 14 May 2015 12:35:43 +0200 Message-ID: <20150514103542.GB5066@rei.suse.de> References: <55536DC9.90200@kyup.com> <20150514092145.GA6799@dhcp22.suse.cz> <20150514092301.GB6799@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20150514092301.GB6799@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org, Nikolay Borisov Hi! > --- a/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > +++ b/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > @@ -158,17 +158,12 @@ testcase_21() > # Case 22 - 24: Test limit_in_bytes will be aligned to PAGESIZE > testcase_22() > { > - test_limit_in_bytes $((PAGESIZE-1)) $PAGESIZE 0 > + test_limit_in_bytes $((PAGESIZE-1)) 0 0 > } > > testcase_23() > { > - test_limit_in_bytes $((PAGESIZE+1)) $((PAGESIZE*2)) 0 > -} > - > -testcase_24() > -{ > - test_limit_in_bytes 1 $PAGESIZE 0 > + test_limit_in_bytes $((PAGESIZE+1)) $((PAGESIZE)) 0 > } That would fail on older kernels without the patch, woudln't it? If we are going to fix it, we should do that in backward compatible fashion. So either we modify the testcases to accept both rounding up and rounding down or choose what we expect based on kernel version. -- Cyril Hrubis chrubis@suse.cz -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org