From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH -mm 1/2] memcg: remove unused mem_cgroup->oom_wakeups Date: Wed, 3 Jun 2015 15:48:30 +0200 Message-ID: <20150603134830.GD16201@dhcp22.suse.cz> References: <20150603023824.GA7579@mtj.duckdns.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20150603023824.GA7579-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: Johannes Weiner , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Andrew Morton On Wed 03-06-15 11:38:24, Tejun Heo wrote: > From 92c2a5d90ecc5eeed0224a8f6ba533c621ac3ffa Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Tue, 2 Jun 2015 09:29:11 -0400 > > Since 4942642080ea ("mm: memcg: handle non-error OOM situations more > gracefully"), nobody uses mem_cgroup->oom_wakeups. Remove it. > > Signed-off-by: Tejun Heo Acked-by: Michal Hocko > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 86648a7..9f39647 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -287,7 +287,6 @@ struct mem_cgroup { > > bool oom_lock; > atomic_t under_oom; > - atomic_t oom_wakeups; > > int swappiness; > /* OOM-Killer disable */ > @@ -1852,7 +1851,6 @@ static int memcg_oom_wake_function(wait_queue_t *wait, > > static void memcg_wakeup_oom(struct mem_cgroup *memcg) > { > - atomic_inc(&memcg->oom_wakeups); > /* for filtering, pass "memcg" as argument. */ > __wake_up(&memcg_oom_waitq, TASK_NORMAL, 0, memcg); > } > -- > 2.4.2 > -- Michal Hocko SUSE Labs