From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH 1/2] memcg: flatten task_struct->memcg_oom Date: Tue, 15 Sep 2015 09:37:30 +0200 Message-ID: <20150915073730.GD2858@cmpxchg.org> References: <20150913185940.GA25369@htj.duckdns.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20150913185940.GA25369-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Sun, Sep 13, 2015 at 02:59:40PM -0400, Tejun Heo wrote: > task_struct->memcg_oom is a sub-struct containing fields which are > used for async memcg oom handling. Most task_struct fields aren't > packaged this way and it can lead to unnecessary alignment paddings. > This patch flattens it. > > * task.memcg_oom.memcg -> task.memcg_in_oom > * task.memcg_oom.gfp_mask -> task.memcg_oom_gfp_mask > * task.memcg_oom.order -> task.memcg_oom_order > * task.memcg_oom.may_oom -> task.memcg_may_oom > > In addition, task.memcg_may_oom is relocated to where other bitfields > are which reduces the size of task_struct. > > Signed-off-by: Tejun Heo > Acked-by: Michal Hocko > Reviewed-by: Vladimir Davydov Looks good to me, thanks. Acked-by: Johannes Weiner