From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jakub Kunert <kuba.kunert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/6] cgroup: Remove prohibited white spaces
Date: Tue, 15 Dec 2015 12:06:33 -0500 [thread overview]
Message-ID: <20151215170633.GD4026@mtj.duckdns.org> (raw)
In-Reply-To: <1450182045-27480-1-git-send-email-kuba.kunert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello, Jakub.
On Tue, Dec 15, 2015 at 01:20:40PM +0100, Jakub Kunert wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: space prohibited before open square bracket
>
> Signed-off-by: Jakub Kunert <kuba.kunert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
...
> /* generate an array of cgroup subsystem pointers */
> -#define SUBSYS(_x) [_x ## _cgrp_id] = &_x ## _cgrp_subsys,
> +#define SUBSYS(_x)[_x ## _cgrp_id] = &_x ## _cgrp_subsys,
Don't follow the checkpatch.pl output without thinking. No space
before opening brackets rule clearly isn't for cases like above.
--
tejun
next prev parent reply other threads:[~2015-12-15 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 12:20 [PATCH 1/6] cgroup: Remove prohibited white spaces Jakub Kunert
[not found] ` <1450182045-27480-1-git-send-email-kuba.kunert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-15 12:20 ` [PATCH 2/6] cgroup: Fix line length to 80 characters Jakub Kunert
[not found] ` <1450182045-27480-2-git-send-email-kuba.kunert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-15 17:11 ` Tejun Heo
2015-12-15 12:20 ` [PATCH 3/6] cgroup: Fix trailing */ in block comments Jakub Kunert
2015-12-15 12:20 ` [PATCH 4/6] cgroup: Add blank lines after declarations Jakub Kunert
2015-12-15 12:20 ` [PATCH 5/6] cgroup: Replace printk(KERN_INFO) with pr_info() Jakub Kunert
2015-12-15 12:20 ` [PATCH 6/6] cgroup: Move constant to the right site of comparison Jakub Kunert
2015-12-15 17:06 ` Tejun Heo [this message]
2015-12-16 1:22 ` [PATCH 1/6] cgroup: Remove prohibited white spaces Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215170633.GD4026@mtj.duckdns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kuba.kunert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).