From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH 3/5] mm: workingset: separate shadow unpacking and refault calculation Date: Wed, 27 Jan 2016 17:34:41 +0300 Message-ID: <20160127143440.GC9623@esperanza> References: <1453842006-29265-1-git-send-email-hannes@cmpxchg.org> <1453842006-29265-4-git-send-email-hannes@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1453842006-29265-4-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Tue, Jan 26, 2016 at 04:00:04PM -0500, Johannes Weiner wrote: > Per-cgroup thrash detection will need to derive a live memcg from the > eviction cookie, and doing that inside unpack_shadow() will get nasty > with the reference handling spread over two functions. > > In preparation, make unpack_shadow() clearly about extracting static > data, and let workingset_refault() do all the higher-level handling. > > Signed-off-by: Johannes Weiner Reviewed-by: Vladimir Davydov