From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: adityakali-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: cgroup: introduce cgroup namespaces
Date: Wed, 17 Feb 2016 21:58:11 +0300 [thread overview]
Message-ID: <20160217185811.GA3472@mwanda> (raw)
Hello Aditya Kali,
The patch a79a908fd2b0: "cgroup: introduce cgroup namespaces" from
Jan 29, 2016, leads to the following static checker warning:
kernel/cgroup.c:6091 copy_cgroup_ns()
error: 'new_ns' dereferencing possible ERR_PTR()
kernel/cgroup.c
6085
6086 err = -ENOMEM;
6087 new_ns = alloc_cgroup_ns();
6088 if (!new_ns)
^^^^^^^
This should be an IS_ERR() check.
6089 goto err_out;
6090
6091 new_ns->user_ns = get_user_ns(user_ns);
regards,
dan carpenter
next reply other threads:[~2016-02-17 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:58 Dan Carpenter [this message]
2016-02-18 16:46 ` [PATCH cgroup/for-4.5-fixes] cgroup: fix alloc_cgroup_ns() error handling in copy_cgroup_ns() Tejun Heo
[not found] ` <20160218164658.GD13177-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-02-18 16:57 ` Aditya Kali
2016-02-18 20:21 ` Dan Carpenter
2016-02-18 20:26 ` Tejun Heo
[not found] ` <20160218202650.GH13177-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-02-18 21:26 ` Dan Carpenter
2016-02-28 13:59 ` [PATCH cgroup/for-4.6-ns] cgroup: fix and restructure " Tejun Heo
[not found] ` <20160228135933.GT3965-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-02-29 8:50 ` Serge Hallyn
2016-02-29 21:23 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217185811.GA3472@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=adityakali-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).