From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list Date: Wed, 8 Jun 2016 09:25:54 +0200 Message-ID: <20160608072554.GD22570@dhcp22.suse.cz> References: <1465369248-13865-1-git-send-email-roy.qing.li@gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1465369248-13865-1-git-send-email-roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, vdavydov-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org On Wed 08-06-16 15:00:48, roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Li RongQing > > when call uncharge_list, if a page is transparent huge, and not need to > BUG_ON about non-transparent huge, since nobody should be be seeing the > page at this stage and this page cannot be raced with a THP split up Johannes do you remember why you have kept this bug on even after 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API")? > Signed-off-by: Li RongQing > --- > mm/memcontrol.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 4d9a215..d7a56f1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5457,7 +5457,6 @@ static void uncharge_list(struct list_head *page_list) > > if (PageTransHuge(page)) { > nr_pages <<= compound_order(page); > - VM_BUG_ON_PAGE(!PageTransHuge(page), page); > nr_huge += nr_pages; > } > > -- > 2.1.4 -- Michal Hocko SUSE Labs