From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Balbir Singh <bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [RFC][PATCH] cgroup_threadgroup_rwsem - affects scalability and OOM
Date: Tue, 9 Aug 2016 10:26:03 -0400 [thread overview]
Message-ID: <20160809142603.GE4906@mtj.duckdns.org> (raw)
In-Reply-To: <0a7ffe43-c0c6-85df-9bc2-d00fc837e284-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello, Balbir.
On Tue, Aug 09, 2016 at 05:02:47PM +1000, Balbir Singh wrote:
> > Hmm? Where does mem_cgroup_iter grab cgroup_mutex? cgroup_mutex nests
> > outside cgroup_threadgroup_rwsem or most other mutexes for that matter
> > and isn't exposed from cgroup core.
> >
>
> I based my theory on the code
>
> mem_cgroup_iter -> css_next_descendant_pre which asserts
>
> cgroup_assert_mutex_or_rcu_locked(),
>
> although you are right, we hold RCU lock while calling css_* routines.
That's "or". The iterator can be called either with RCU lock or
cgroup_mutex. cgroup core may use it under cgroup_mutex. Everyone
else uses it with rcu.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-08-09 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 4:19 [RFC][PATCH] cgroup_threadgroup_rwsem - affects scalability and OOM Balbir Singh
[not found] ` <4717ef90-ca86-4a34-c63a-94b8b4bfaaec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-09 6:29 ` Tejun Heo
2016-08-09 7:02 ` Balbir Singh
[not found] ` <0a7ffe43-c0c6-85df-9bc2-d00fc837e284-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-09 14:26 ` Tejun Heo [this message]
[not found] ` <20160809142603.GE4906-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-08-10 1:21 ` Balbir Singh
2016-08-09 9:00 ` Zefan Li
2016-08-09 13:57 ` Balbir Singh
2016-08-10 1:31 ` Zefan Li
2016-08-09 18:09 ` Oleg Nesterov
2016-08-10 19:43 ` Tejun Heo
[not found] ` <20160810194306.GP25053-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-08-11 23:47 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809142603.GE4906@mtj.duckdns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).