From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [RFC][PATCH] cgroup_threadgroup_rwsem - affects scalability and OOM Date: Tue, 9 Aug 2016 20:09:36 +0200 Message-ID: <20160809180936.GE13840@redhat.com> References: <4717ef90-ca86-4a34-c63a-94b8b4bfaaec@gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <4717ef90-ca86-4a34-c63a-94b8b4bfaaec@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Balbir Singh Cc: cgroups@vger.kernel.org, Andrew Morton , Tejun Heo , "linux-mm@kvack.org" On 08/09, Balbir Singh wrote: > > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1406,7 +1406,6 @@ static struct task_struct *copy_process(unsigned long clone_flags, > p->real_start_time = ktime_get_boot_ns(); > p->io_context = NULL; > p->audit_context = NULL; > - threadgroup_change_begin(current); > cgroup_fork(p); > #ifdef CONFIG_NUMA > p->mempolicy = mpol_dup(p->mempolicy); > @@ -1558,6 +1557,7 @@ static struct task_struct *copy_process(unsigned long clone_flags, > INIT_LIST_HEAD(&p->thread_group); > p->task_works = NULL; > > + threadgroup_change_begin(current); > /* > * Ensure that the cgroup subsystem policies allow the new process to be > * forked. It should be noted the the new process's css_set can be changed > @@ -1658,6 +1658,7 @@ static struct task_struct *copy_process(unsigned long clone_flags, > bad_fork_cancel_cgroup: > cgroup_cancel_fork(p); > bad_fork_free_pid: > + threadgroup_change_end(current); > if (pid != &init_struct_pid) > free_pid(pid); > bad_fork_cleanup_thread: > @@ -1690,7 +1691,6 @@ bad_fork_cleanup_policy: > mpol_put(p->mempolicy); > bad_fork_cleanup_threadgroup_lock: > #endif > - threadgroup_change_end(current); > delayacct_tsk_free(p); > bad_fork_cleanup_count: > atomic_dec(&p->cred->user->processes); I can't really review this change... but it looks good to me. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org