From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mike Galbraith <efault-Mmb7MZpHnFY@public.gmane.org>,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH cgroup/for-4.10-fixes] cgroup/pids: remove spurious suspicious RCU usage warning
Date: Mon, 6 Mar 2017 15:12:00 -0500 [thread overview]
Message-ID: <20170306201200.GI19696@htj.duckdns.org> (raw)
In-Reply-To: <20170301203907.GF3662-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
On Wed, Mar 01, 2017 at 03:39:07PM -0500, Tejun Heo wrote:
> pids_can_fork() is special in that the css association is guaranteed
> to be stable throughout the function and thus doesn't need RCU
> protection around task_css access. When determining the css to charge
> the pid, task_css_check() is used to override the RCU sanity check.
>
> While adding a warning message on fork rejection from pids limit,
> 135b8b37bd91 ("cgroup: Add pids controller event when fork fails
> because of pid limit") incorrectly added a task_css access which is
> neither RCU protected or explicitly annotated. This triggers the
> following suspicious RCU usage warning when RCU debugging is enabled.
Applied to cgroup/for-4.11-fixes.
--
tejun
prev parent reply other threads:[~2017-03-06 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1487585723.8499.5.camel@gmx.de>
[not found] ` <20170301174452.GE3662@htj.duckdns.org>
[not found] ` <1488391071.4812.2.camel@gmx.de>
2017-03-01 20:39 ` [PATCH cgroup/for-4.10-fixes] cgroup/pids: remove spurious suspicious RCU usage warning Tejun Heo
[not found] ` <20170301203907.GF3662-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2017-03-06 20:12 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306201200.GI19696@htj.duckdns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=efault-Mmb7MZpHnFY@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).