From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Gushchin Subject: [PATCH 2/2] cgroup: revert fa06235b8eb0 ("cgroup: reset css on destruction") Date: Thu, 27 Jul 2017 14:04:28 +0100 Message-ID: <20170727130428.28856-2-guro@fb.com> References: <20170726083017.3yzeucmi7lcj46qd@esperanza> <20170727130428.28856-1-guro@fb.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=XftPoh/1tamCeFkG+2j4ZoJPLsuKwot2PiEadyQrnoc=; b=pUkkiP6FjTOgoMDzWOPN/AY7q5NQXBXdb/l9ix4hfLon4MhqGwFZPByIDrP40xrzovtY YSpC7YPKARbsMdZ9bQPDBNwo0unRKo3JZrgjdmMm4X+Sn2VdGbnlgDqAs9u4T2yphaPE dAOXCK/R706+zwp+OXVss4JUb/2BrW0V6Mo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XftPoh/1tamCeFkG+2j4ZoJPLsuKwot2PiEadyQrnoc=; b=KfH3t3ZaXISHdOplcQy83dn6Y9sSocmDgKL8FmBfAJy766j/7bn2oz91wKFrJFopaqG02kj2o5Wv2C4J3zLi5ufIGRGSRiGxoTXVV8Lv2W/z/1xkv9GQPGfccnwaNVrDV2Qd34YnH6fbxXWcGF2Xvl9HchlREXvgHSZY7FO6GDA= In-Reply-To: <20170727130428.28856-1-guro@fb.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: Roman Gushchin , Vladimir Davydov , Tejun Heo , Johannes Weiner , Michal Hocko , kernel-team@fb.com, cgroups@vger.kernel.org, linux-mm@kvack.org Commit fa06235b8eb0 ("cgroup: reset css on destruction") caused css_reset callback to be called from the offlining path. Although it solves the problem mentioned in the commit description ("For instance, memory cgroup needs to reset memory.low, otherwise pages charged to a dead cgroup might never get reclaimed."), generally speaking, it's not correct. An offline cgroup can still be a resource domain, and we shouldn't grant it more resources than it had before deletion. For instance, if an offline memory cgroup has dirty pages, we should still imply i/o limits during writeback. The css_reset callback is designed to return the cgroup state into the original state, that means reset all limits and counters. It's spomething different from the offlining, and we shouldn't use it from the offlining path. Instead, we should adjust necessary settings from the per-controller css_offline callbacks (e.g. reset memory.low). Signed-off-by: Roman Gushchin Cc: Vladimir Davydov Cc: Tejun Heo Cc: Johannes Weiner Cc: Michal Hocko Cc: kernel-team@fb.com Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- kernel/cgroup/cgroup.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 29c36c075249..4e93482e066c 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4499,9 +4499,6 @@ static void offline_css(struct cgroup_subsys_state *css) if (!(css->flags & CSS_ONLINE)) return; - if (ss->css_reset) - ss->css_reset(css); - if (ss->css_offline) ss->css_offline(css); -- 2.13.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org