From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Gushchin Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging Date: Wed, 30 Aug 2017 13:44:59 +0100 Message-ID: <20170830124459.GA10438@castle.DHCP.thefacebook.com> References: <20170829100150.4580-1-guro@fb.com> <20170830123655.6kce7yfkrhrhwubu@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=facebook; bh=a25e7C7FB21SgU5uqMiKYNXEn+ukZqdo53tq34HNV+s=; b=EuTV2jDnFdAIfWnQmIQ4WMPe4yPYD7KcR5QliOC6mUAsLxihbRBTmAWMoD28IvSLqPZa wHPQlwwies32jcgp+wPiKOj6b6vWYxEOpDYQVeLsBB3Uzvh9CTOOfH//YioX/k7TYcs+ FY83E2Q+Gczx5ZNWH3WkmICen6zEPS6YYWM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a25e7C7FB21SgU5uqMiKYNXEn+ukZqdo53tq34HNV+s=; b=fj0lX7vcStYHqAAE0Qy1tSbL8dz6cUoFXHPfOOp2rZ55vZkelYATsEfGLK9CtGsCByRcNpG44aN+dSzfHS8VdQ6+QxOE/u1cvyl899JFJLkDaFMH2hWfKwki4ZegkRmnrkLSGAx3IH0a8Wwa5MOkJxeKwtxo5PO3tJkmOmfyYx4= Content-Disposition: inline In-Reply-To: <20170830123655.6kce7yfkrhrhwubu@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm@kvack.org, Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org On Wed, Aug 30, 2017 at 02:36:55PM +0200, Michal Hocko wrote: > On Tue 29-08-17 11:01:50, Roman Gushchin wrote: > [...] > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index b9cf3cf4a3d0..a69d23082abf 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -1792,6 +1792,9 @@ static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) > > } > > stock->nr_pages += nr_pages; > > > > + if (stock->nr_pages > CHARGE_BATCH) > > + drain_stock(stock); > > + > > local_irq_restore(flags); > > } > > Why do we need this? In other words, why cannot we rely on draining we > already do? The existing draining depends on memory pressure, so to keep the accounting (which we expose to a user) reasonable accurate even without memory pressure, we need to limit the size of per-cpu stocks. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org