From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate_execute() returns
Date: Fri, 22 Sep 2017 08:16:49 -0700 [thread overview]
Message-ID: <20170922151649.GE828415@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1506002053-13380-1-git-send-email-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Thu, Sep 21, 2017 at 09:54:13AM -0400, Waiman Long wrote:
...
> To allow reuse of the cgroup_mgctx structure, some fields in that
> structure are now re-initialized at the end of cgroup_migrate_execute()
> function call so that the structure can be reused again in a later
> iteration without causing problem.
>
> This bug was introduced in the commit e595cd706982 ("group: track
> migration context in cgroup_mgctx") in 4.11. This commit moves the
> cgroup_taskset initialization out of cgroup_migrate(). The commit
> 10467270fb3 ("cgroup: don't call migration methods if there are no
> tasks to migrate") helped, but did not completely resolve the problem.
>
> Fixes: e595cd706982bff0211e6fafe5a108421e747fbc ("group: track migration context in cgroup_mgctx")
> Signed-off-by: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Applied to cgroup/for-4.14-fixes.
Thanks, Waiman!
--
tejun
prev parent reply other threads:[~2017-09-22 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 13:54 [PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate_execute() returns Waiman Long
[not found] ` <1506002053-13380-1-git-send-email-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-22 15:16 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922151649.GE828415@devbig577.frc2.facebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox