Re: [v8 0/4] cgroup-aware OOM killer

David Rientjes
2017-09-11T20:44:39Z

On Mon, 11 Sep 2017, Roman Gushchin wrote:

> This patchset makes the OOM killer cgroup-aware.
>
> v8:
> - Do not kill tasks with OOM_SCORE_ADJ -1000
> - Make the whole thing opt-in with cgroup mount option control
> - Drop oom_priority for further discussions

Nack, we specifically require oom_priority for this to function correctly,
otherwise we cannot prefer to kill from low priority leaf memcgs as
required. v8 appears to implement new functionality that we want, to
compare two memcgs based on usage, but without the ability to influence
that decision to protect important userspace, so now I'm in a position
where (1) nothing has changed if I don't use the new mount option or (2) I
get completely different oom kill selection with the new mount option but
not the ability to influence it. I was much happier with the direction
that v7 was taking, but since v8 causes us to regress without the ability
to change memcg priority, this has to be nacked.

> - Kill the whole cgroup if oom_group is set and it's
> memory.max is reached
> - Update docs and commit messages