From: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat
Date: Thu, 26 Oct 2017 19:43:07 +0200 [thread overview]
Message-ID: <20171026174307.GU3165@worktop.lehotels.local> (raw)
In-Reply-To: <20171023231827.GA8598-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote:
> The basic cpu stat is currently shown with "cpu." prefix in
> cgroup.stat, and the same information is duplicated in cpu.stat when
> cpu controller is enabled. This is ugly and not very scalable as we
> want to expand the coverage of stat information which is always
> available.
>
> This patch makes cgroup core always create "cpu.stat" file and show
> the basic cpu stat there and calls the cpu controller to show the
> extra stats when enabled. This ensures that the same information
> isn't presented in multiple places and makes future expansion of basic
> stats easier.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Documentation/cgroup-v2.txt | 15 +++-------
> include/linux/cgroup-defs.h | 2 +
> include/linux/cgroup.h | 2 -
> kernel/cgroup/cgroup-internal.h | 1
> kernel/cgroup/cgroup.c | 60 ++++++++++++++++++++++++++++++++++++++--
> kernel/cgroup/stat.c | 10 +++---
> kernel/sched/core.c | 13 ++------
> 7 files changed, 75 insertions(+), 28 deletions(-)
Acked-by: Peter Zijlstra (Intel) <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
next prev parent reply other threads:[~2017-10-26 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 23:18 [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat Tejun Heo
[not found] ` <20171023231827.GA8598-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-10-24 8:35 ` Peter Zijlstra
[not found] ` <20171024083504.GM3165-IIpfhp3q70x9+YH6RuovlLjjLBE8jN/0@public.gmane.org>
2017-10-24 14:59 ` Tejun Heo
2017-10-26 17:43 ` Peter Zijlstra [this message]
2017-10-26 17:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026174307.GU3165@worktop.lehotels.local \
--to=peterz-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=guro-b10kYP2dOMg@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox