cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive
@ 2017-12-11 14:56 weiping zhang
       [not found] ` <20171211145621.GA2115-bi+AKbBUZKZw6VQDmTdmGHWcxnUbehklAL8bYrjMMd8@public.gmane.org>
  2018-01-18 19:56 ` Jens Axboe
  0 siblings, 2 replies; 5+ messages in thread
From: weiping zhang @ 2017-12-11 14:56 UTC (permalink / raw)
  To: axboe, tj, shli, lizefan; +Cc: linux-block, cgroups

export these two interface for cgroup-v1.

Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
---
 block/blk-throttle.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 96ad326..1d7637f 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -1512,10 +1512,20 @@ static struct cftype throtl_legacy_files[] = {
 		.seq_show = blkg_print_stat_bytes,
 	},
 	{
+		.name = "throttle.io_service_bytes_recursive",
+		.private = (unsigned long)&blkcg_policy_throtl,
+		.seq_show = blkg_print_stat_bytes_recursive,
+	},
+	{
 		.name = "throttle.io_serviced",
 		.private = (unsigned long)&blkcg_policy_throtl,
 		.seq_show = blkg_print_stat_ios,
 	},
+	{
+		.name = "throttle.io_serviced_recursive",
+		.private = (unsigned long)&blkcg_policy_throtl,
+		.seq_show = blkg_print_stat_ios_recursive,
+	},
 	{ }	/* terminate */
 };
 
-- 
2.9.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive
       [not found] ` <20171211145621.GA2115-bi+AKbBUZKZw6VQDmTdmGHWcxnUbehklAL8bYrjMMd8@public.gmane.org>
@ 2017-12-11 15:17   ` Tejun Heo
       [not found]     ` <20171211151705.GG2421075-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2017-12-11 15:17 UTC (permalink / raw)
  To: axboe-tSWWG44O7X1aa/9Udqfwiw, shli-DgEjT+Ai2ygdnm+yROfE0A,
	lizefan-hv44wF8Li93QT0dZR+AlfA,
	linux-block-u79uwXL29TY76Z2rM5mHXA,
	cgroups-u79uwXL29TY76Z2rM5mHXA

On Mon, Dec 11, 2017 at 10:56:25PM +0800, weiping zhang wrote:
> export these two interface for cgroup-v1.
> 
> Signed-off-by: weiping zhang <zhangweiping-j11cvHKnkmPwvR0lvYjcXw@public.gmane.org>

Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive
       [not found]     ` <20171211151705.GG2421075-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
@ 2017-12-29 17:17       ` weiping zhang
  2018-01-18 15:41       ` weiping zhang
  1 sibling, 0 replies; 5+ messages in thread
From: weiping zhang @ 2017-12-29 17:17 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Jens Axboe, Shaohua Li, lizefan-hv44wF8Li93QT0dZR+AlfA,
	linux-block-u79uwXL29TY76Z2rM5mHXA,
	cgroups-u79uwXL29TY76Z2rM5mHXA

2017-12-11 23:17 GMT+08:00 Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> On Mon, Dec 11, 2017 at 10:56:25PM +0800, weiping zhang wrote:
>> export these two interface for cgroup-v1.
>>
>> Signed-off-by: weiping zhang <zhangweiping-j11cvHKnkmPwvR0lvYjcXw@public.gmane.org>
>
> Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> Thanks.
>

Hi Jens,

these two interface are useful to collect blkcg info, would you pick it up ?

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive
       [not found]     ` <20171211151705.GG2421075-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
  2017-12-29 17:17       ` weiping zhang
@ 2018-01-18 15:41       ` weiping zhang
  1 sibling, 0 replies; 5+ messages in thread
From: weiping zhang @ 2018-01-18 15:41 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Tejun Heo, Shaohua Li, lizefan-hv44wF8Li93QT0dZR+AlfA,
	linux-block-u79uwXL29TY76Z2rM5mHXA,
	cgroups-u79uwXL29TY76Z2rM5mHXA

2017-12-11 23:17 GMT+08:00 Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> On Mon, Dec 11, 2017 at 10:56:25PM +0800, weiping zhang wrote:
>> export these two interface for cgroup-v1.
>>
>> Signed-off-by: weiping zhang <zhangweiping-j11cvHKnkmPwvR0lvYjcXw@public.gmane.org>
>
> Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>

Hi Jens,

Have you got time to check this patch ?

Thanks

> Thanks.
>
> --
> tejun

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive
  2017-12-11 14:56 [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive weiping zhang
       [not found] ` <20171211145621.GA2115-bi+AKbBUZKZw6VQDmTdmGHWcxnUbehklAL8bYrjMMd8@public.gmane.org>
@ 2018-01-18 19:56 ` Jens Axboe
  1 sibling, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2018-01-18 19:56 UTC (permalink / raw)
  To: tj, shli, lizefan, linux-block, cgroups

On 12/11/17 7:56 AM, weiping zhang wrote:
> export these two interface for cgroup-v1.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-18 19:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 14:56 [RFC] blk-throttle: export io_serviced_recursive, io_service_bytes_recursive weiping zhang
     [not found] ` <20171211145621.GA2115-bi+AKbBUZKZw6VQDmTdmGHWcxnUbehklAL8bYrjMMd8@public.gmane.org>
2017-12-11 15:17   ` Tejun Heo
     [not found]     ` <20171211151705.GG2421075-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-12-29 17:17       ` weiping zhang
2018-01-18 15:41       ` weiping zhang
2018-01-18 19:56 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).